awslabs / amazon-kinesis-video-streams-webrtc-sdk-android

Android SDK for interfacing with Amazon Kinesis Video Streams Signaling Service.
Apache License 2.0
58 stars 37 forks source link

Add Cognito app client secret instructions comment #111

Closed stefankiesz closed 4 months ago

stefankiesz commented 4 months ago

Explicitly instruct the user with how to enter Cognito app client secret into awsconfiguration.json when the app client is not configured to use a secret. This will clear up confusion which may arise due to the KVS WebRTC iOS SDK requiring the whole AppClientSecret JSON property be removed in awsconfiguration.json for such a case while here in the Android app, it can be either set to an empty string or completely removed.

This is especially helpful considering that the default value for "Client secret" when creating an app client on the AWS console is "Don't generate a client secret".


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.