awslabs / amazon-kinesis-video-streams-webrtc-sdk-android

Android SDK for interfacing with Amazon Kinesis Video Streams Signaling Service.
Apache License 2.0
58 stars 37 forks source link

WebRTC Ingestion Feature #88

Closed sirknightj closed 1 year ago

sirknightj commented 1 year ago

Description of changes:

Before After
image (9) image (10)
Screenshot Note
image (12) If the Media Storage Configuration is not set to ENABLED. To enable it, use the UpdateMediaStorageConfiguration API.
image (11) If the Audio and Video checkboxes are not both checked. The WebRTC ingestion feature currently requires both audio and video tracks to be sent.
Success Failure
image image

Warning The WebRTC ingestion feature requires that the device have H.264 support. Google's WebRTC will throw ERROR_CONTENT. Emulators might not support H.264, so it is recommend to try this feature using a real android device.

Bug Fixes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hassanctech commented 1 year ago

Very nice work @sirknightj !

sirknightj commented 1 year ago
image

Added toast for when credentials returns empty access key/secret key and bail out early.

unicornss commented 1 year ago

lgtm