search

awslabs / amazon-kinesis-video-streams-webrtc-sdk-c

Amazon Kinesis Video Streams Webrtc SDK is for developers to install and customize realtime communication between devices and enable secure streaming of video, audio to Kinesis Video Streams.
https://awslabs.github.io/amazon-kinesis-video-streams-webrtc-sdk-c/group__PublicMemberFunctions.html
Apache License 2.0
1.04k stars 318 forks source link

[QUESTION] Is the priority of remote candidate always zero? #1011

Closed yuma-m closed 3 years ago

yuma-m commented 3 years ago

It looks the priority of remote candidates is always 0 because it is not calculated in iceAgentAddRemoteCandidate function. https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/blob/04c86e0c115b57631b1ff49900a61d12eeea0f3f/src/source/Ice/IceAgent.c#L349-L350

On the other hand, the priority of remote candidates is used in computeCandidatePairPriority function. https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/blob/04c86e0c115b57631b1ff49900a61d12eeea0f3f/src/source/Ice/IceAgent.c#L2647-L2648

I think the priority is defined in RFC 8445 (originally RFC 5245?), is this behavior correct? If the priority of the remote candidate is actually calculated in another part, please let me know.

Thank you.

suggestedfixes commented 3 years ago

I'm a fellow user, this is not an official PR, pending approval.

hassanctech commented 3 years ago

I've merged the PR, closing this issue.