Closed LiuAriel closed 3 years ago
Hello @juno52wendy ,
Thank you for your active contributions. On extracting the zip file, the folder is empty. Can you open a PR with your changes instead? It would be easier to review by the team. Thanks!
Hello @juno52wendy ,
Thank you for your active contributions. On extracting the zip file, the folder is empty. Can you open a PR with your changes instead? It would be easier to review by the team. Thanks!
1.I'm really sorry, I didn't put the modified files yesterday because of negligence. I uploaded a new zip file because the company's regulations do not allow private PR to GitHub and other related warehouses. Please understand. 2.The selectedcandidatepairchange callback and getSelectedCandidatePair api were also implemented before, https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/issues/302 but the feedback needs to be in accordance with the 3C standard. If possible, tell the detailed 3C implementation address, which can be modified as described above. 3.Source code project:webrtc_modify_2020.4.3.zip
@disa6302 Use tools to find keywords: modify by juno 2020.4.2, that is, modify the log part
Thanks @juno52wendy ,
Will review it and get back to you. Again, thanks for your contributions!
@juno52wendy , I went through the file you sent and have a couple of questions:
LogPrintFunc
in the file you sent. Can you point me to this definition. globalCustomLogPrintFn
defined?@juno52wendy , I went through the file you sent and have a couple of questions:
- I am still unclear on what the change is trying to achieve. Can you detail more?
- I am unable to find the definition of
LogPrintFunc
in the file you sent. Can you point me to this definition.- Where is
globalCustomLogPrintFn
defined?
@juno52wendy Thanks for the codebase. Some of the changes are generic indeed to be added into the master branch. I think we would benefit from being able to overwrite some of the platform level callbacks including logging.
I think we should separately track the platform level callbacks from the WebRTC specific feature work.
Will update as soon as possible
Closing this since it has gone stale. Custom log functions can be passed as part of createFileLogger()
invocation.