awslabs / amazon-kinesis-video-streams-webrtc-sdk-c

Amazon Kinesis Video Streams Webrtc SDK is for developers to install and customize realtime communication between devices and enable secure streaming of video, audio to Kinesis Video Streams.
https://awslabs.github.io/amazon-kinesis-video-streams-webrtc-sdk-c/group__PublicMemberFunctions.html
Apache License 2.0
997 stars 299 forks source link

[BUG] Logical error in freeSampleConfiguration #935

Closed Nomidia closed 3 years ago

Nomidia commented 3 years ago

https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/blob/27b95a928c05810f901949fa02364acdb17b16e3/samples/Common.c#L834-L843

CHK should be before use.

lherman-cs commented 3 years ago

@Nomidia thanks for reporting this. This is definitely an error, the fix has been created here, https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/pull/936.