search

awslabs / amazon-kinesis-video-streams-webrtc-sdk-ios

iOS SDK for interfacing with the Amazon Kinesis Video Streams Signaling Service.
Apache License 2.0
61 stars 28 forks source link

Multiple viewer unable to connect simultaneously #16

Open deepaksaxenakent opened 3 years ago

deepaksaxenakent commented 3 years ago

When a single master publishing Audio-video stream and 1 viewer is subscribing that stream and another viewer wants to subscribe then the whole system hangs and the publisher stops working

Scenario Steps:

  1. Master starts publishing the stream on channel ‘A’
  2. Viewer V1 connects and subscribe Channel A’ and can see and publish Audio-video
  3. Viewer V2 connects and want to subscribe to the Channel ‘A’

Expected Result: Both viewer and the master simultaneously Result Observed: When V2 connects then all Master viewers stuck

krishnanganapathy-amazon commented 3 years ago

Hi deepak. Can you post the error logs that you are receiving while executing this use-case ?

Regards Krishnan

deepaksaxenakent commented 3 years ago

Master side - log with 2 viewer.txt Viewer side - log KinisisViewerLogsMultipleViewerSingleMAster.txt

sharadrj commented 3 years ago

Hi Deepak,

Can you describe your test environment on master and viewer side? Did you get this result with our stock samples or made any changes also?

deepaksaxenakent commented 3 years ago

Please find the details below: iPhone Device version - 13.6 and 12.4.8 test only on real devices

Kinesis iOS SDK version -

deepaksaxenakent commented 3 years ago

I have posted the below details on GitHub and we are using stock sample only adding Mr. Jai to the mailing list

Please find the details below:

iPhone Device version - 13.6 and 12.4.8 test only on real devices

Kinesis iOS SDK version and dependencies:

Best Regards, Deepak Saxena Sr Software Engineer, Product Development

[KENT] www.kentcam.com KENT Cam Technologies (A division of Kent RO Systems Ltd.) E-6,7,8 Sector 59, Noida, Uttar Pradesh - 201309, Phone: +91-120-3075000 Mobile: +91-9560270789 [cid:facebook_f55fb7fd-391d-44b1-a462-f1b7b6566056.png]https://www.facebook.com/viewKENTCam [cid:twitter_86997126-672a-4922-8438-6a83aaf5951f.png] https://twitter.com/viewKENTCam [cid:linkedin_15241a70-9365-4c8f-9642-9da4d4f62500.png] https://www.linkedin.com/company/view-kent-cam/ [cid:youtube_705ba0ca-504f-4e20-8cd2-5a64f1330703.png] https://www.youtube.com/c/KENTCam/

On 10-Sep-2020, at 11:53 AM, sharadrj notifications@github.com<mailto:notifications@github.com> wrote:

Hi Deepak,

Can you describe your test environment on master and viewer side? Did you get this result with our stock samples or made any changes also?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-ios/issues/16#issuecomment-690016185, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ5KQVNGNFGM4SKZCZLWO53SFBWEVANCNFSM4Q74BUUQ.

Click herehttps://www.mailcontrol.com/sr/MZbqvYs5QwJvpeaetUwhCQ== to report this email as spam.

This message contains confidential information and is intended only for the individual(s) addressed in the message. If you are not the named addressee, you should not disseminate, distribute, or copy this e-mail. If you are not the intended recipient, you are notified that disclosing, distributing, or copying this e-mail is strictly prohibited. This email and attachments have been scanned for potential proprietary or sensitive information leakage.

dswamina commented 3 years ago

Hi Deepak,

Thanks for all the information! I've reproduced the issue you're facing and we are currently trying to investigate it further.

Thanks, Divya

deepaksaxenakent commented 3 years ago

Hi Divya and Team Hope you get a chance to look into the issue, may you please update us, we are waiting to integrate it.

Best Regards, Deepak Saxena Sr Software Engineer, Product Development

[KENT] www.kentcam.com KENT Cam Technologies (A division of Kent RO Systems Ltd.) E-6,7,8 Sector 59, Noida, Uttar Pradesh - 201309, Phone: +91-120-3075000 Mobile: +91-9560270789 [cid:facebook_f55fb7fd-391d-44b1-a462-f1b7b6566056.png]https://www.facebook.com/viewKENTCam [cid:twitter_86997126-672a-4922-8438-6a83aaf5951f.png] https://twitter.com/viewKENTCam [cid:linkedin_15241a70-9365-4c8f-9642-9da4d4f62500.png] https://www.linkedin.com/company/view-kent-cam/ [cid:youtube_705ba0ca-504f-4e20-8cd2-5a64f1330703.png] https://www.youtube.com/c/KENTCam/

On 15-Sep-2020, at 1:51 AM, dswamina notifications@github.com<mailto:notifications@github.com> wrote:

Hi Deepak,

Thanks for all the information! I've reproduced the issue you're facing and we are currently trying to investigate it further.

Thanks, Divya

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-ios/issues/16#issuecomment-692291958, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ5KQVLR5335AZVY63JSVT3SFZ3MLANCNFSM4Q74BUUQ.

Click herehttps://www.mailcontrol.com/sr/MZbqvYs5QwJvpeaetUwhCQ== to report this email as spam.

This message contains confidential information and is intended only for the individual(s) addressed in the message. If you are not the named addressee, you should not disseminate, distribute, or copy this e-mail. If you are not the intended recipient, you are notified that disclosing, distributing, or copying this e-mail is strictly prohibited. This email and attachments have been scanned for potential proprietary or sensitive information leakage.

deepaksaxenakent commented 3 years ago

Hi Divya and Team Hope you get a chance to look into the issue, may you please update us, we are waiting to integrate it.

dswamina commented 3 years ago

Hi Deepak,

Please refer to the sample in this branch : https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-ios/tree/multiple-viewer-sample

Hope this helps!

Thanks, Divya

dswamina commented 3 years ago

Hi Deepak,

Can you verify if the region in the sample is correct? The crash logs are pointing to 'a invalid region type'. Can you please confirm?

Thanks, Divya

deepaksaxenakent commented 3 years ago
  1. On physical device iOS 12.4.8 
Line number 169 in WebRTCClient its crashing I.e remoteVideoTrack?.add(self.remoteRenderer!) because of finding self.remoteRenderer to nil.
  2. Unable to run the project on simulator (compile-time error)

// Primary can show only one remoteVideoTrack of Viewer1 on the UI. // All the other remote tracks from viewers are ignored and not added to the remoteRenderer. if (self.peerConnectionMap.count < 2) { remoteVideoTrack = peerConnection.transceivers.first { $0.mediaType == .video }?.receiver.track as? RTCVideoTrack remoteVideoTrack?.add(self.remoteRenderer!) // Crashes here }

MushMal commented 3 years ago

@dswamina do you have any further update on this issue?

@deepaksaxenakent has your original issue been resolved?

I would like to get more traction on this issue and not let it go stale