search

awslabs / amazon-kinesis-video-streams-webrtc-sdk-js

JS SDK for interfacing with the Amazon Kinesis Video Streams Signaling Service.
https://awslabs.github.io/amazon-kinesis-video-streams-webrtc-sdk-js/examples/index.html
Apache License 2.0
286 stars 141 forks source link

Handle caching of ICE candidates #114

Closed disa6302 closed 3 years ago

disa6302 commented 3 years ago

Because of out of order signaling message delivery, it is possible that the ICE candidates arrive before the answer in trickle ICE mode and the SDK does not track these ICE candidates. In the sample, we need to implement a caching logic to store any ICE candidates that are received before getting an answer to ensure we do not lose these while creating candidate pairs. The WebRTC C SDK handles this, but other SDKs do not.

disa6302 commented 3 years ago

This is already implemented here: https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-js/blob/749e5d231fd88ddf82545e84ae22f8578c1b6ae7/src/SignalingClient.ts#L259

Closing.