awslabs / amazon-kinesis-video-streams-webrtc-sdk-js

JS SDK for interfacing with the Amazon Kinesis Video Streams Signaling Service.
https://awslabs.github.io/amazon-kinesis-video-streams-webrtc-sdk-js/examples/index.html
Apache License 2.0
286 stars 141 forks source link

Adds STUN only option on WebRTC test page #239

Closed awanurag closed 1 year ago

awanurag commented 1 year ago

Issue #, if available:

Description of changes: Adds STUN only option on WebRTC test page. Helps with testing from behind a router (using STUN) on public internet (without TURN).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sirknightj commented 1 year ago

Hey @awanurag, thanks for your contribution.

Can you also save the new option to localstorage so it's not lost upon refresh? You can do that by adding your new field around app.js:376.

Thanks!

awanurag commented 1 year ago

Hey @sirknightj , added forceSTUN option to localStorage object.

sirknightj commented 1 year ago

Thanks! These changes should go live shortly.

https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-js/actions/runs/5395321851/jobs/9797653198 to keep track of the github pages publish task.