awslabs / amazon-omics-tools

Apache License 2.0
24 stars 6 forks source link

run analyzer fails on run with cache #77

Open avigailmo opened 2 days ago

avigailmo commented 2 days ago

When I try to run the run_analyzer on a run that configured to run with run_cache (no matter if there were cache hits or not) it fails with the following error: File "omics/cli/run_analyzer/main.py", line 460, in resources = get_run_resources(logs, runs[0]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "omics/cli/run_analyzer/main.py", line 257, in get_run_resources return sorted(resources, key=lambda x: x.get("creationTime")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: '<' not supported between instances of 'NoneType' and 'str'

example to such run: arn:aws:omics:us-east-1:891377049375:run/9748207 I run the command without any flag: python -m omics.cli.run_analyzer 9748207

markjschreiber commented 2 days ago

Thanks for reporting this. Looks like this line of code needs to provide a default time if the creationTime doesn't exist so that the results can be sorted. https://github.com/awslabs/amazon-omics-tools/blob/main/omics/cli/run_analyzer/__main__.py#L257C5-L257C66

I think in other parts of the code we have used the arbitrary default date of 1970-01-01