search

awslabs / amazon-qldb-driver-nodejs

A NodeJs implementation of a driver for Amazon QLDB.
https://aws.amazon.com/qldb/?nc2=h_ql_prod_db_qldb
Apache License 2.0
53 stars 22 forks source link

Add missing Smithy dependencies #636

Closed gscalise closed 7 months ago

gscalise commented 8 months ago

Description of changes: Added explicit dependencies to @smithy/smithy-client and @smithy/node-http-handler, as they were not declared, which causes phantom dependency issues in non-hoisting package managers such as pnpm (with hoisting disabled, as used by Bazel, for example). I've chosen the same version qualifier/selector that is used in transitive dependencies to avoid any unexpected package version variations. This should not affect any of this package's consumers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gscalise commented 8 months ago

@trstephen-amazon , as agreed, here's the PR with the fix for the phantom dependency issues.

trstephen-amazon commented 8 months ago

CI failures should be addressed by #637 . Now how do I rebase a PR...

trstephen-amazon commented 8 months ago

Not sure what the issue is with the creds workflow. I'm surprised the rebase doesn't work.

Maybe it needs a brand new PR? It seems to be working for #634 -> #638.

Can you try a rebase and new PR @gscalise ? Apologies for all the runaround.