changed drop to inplace to avoid redundant copy

awslabs / amazon-sagemaker-workshop

Amazon SageMaker workshops: Introduction, TensorFlow in SageMaker, and more

Apache License 2.0

381 stars 211 forks source link

changed drop to inplace to avoid redundant copy #10

Closed kylejones200 closed 4 years ago

kylejones200 commented 4 years ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kylejones200 commented 4 years ago

Original version reassigned the Pandas DataDrame to the same variable name which creates a copy of the original dataframe. Using the "inplace" argument allows the changes to be done without making a copy. This version is faster, uses less memory, and is a better practice for clean Pandas code.

rabowskyb commented 4 years ago

Hello, I am closing this PR since it appears similar to the other one you filed the same day, #11.