awslabs / amazon-sagemaker-workshop

Amazon SageMaker workshops: Introduction, TensorFlow in SageMaker, and more
Apache License 2.0
381 stars 211 forks source link

Videogame sales #11

Closed kylejones200 closed 4 years ago

kylejones200 commented 4 years ago

Issue #, if available:

Description of changes: Original version reassigned the Pandas DataDrame to the same variable name which creates a copy of the original dataframe. Using the "inplace" argument allows the changes to be done without making a copy. This version is faster, uses less memory, and is a better practice for clean Pandas code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rabowskyb commented 4 years ago

Hello, for small datasets such as this one, creating a few extra copies while doing EDA is pretty typical, concerns with optimal memory utilization aren't paramount. However, if you would like to move forward with a PR, could you please file a new PR for review as follows: 1) Only modifies the notebook .ipynb file -- in this PR, it appears that seven files were modified/added.
2) In the notebook .ipynb file, please make sure that the changes are to a clean notebook (restart kernel - clear all output) with no cell output.