awslabs / amazon-transcribe-streaming-sdk

The Amazon Transcribe Streaming SDK is an async Python SDK for converting audio into text via Amazon Transcribe.
Apache License 2.0
147 stars 38 forks source link

Add Github Actions for Pull Requests #2

Closed nateprewitt closed 4 years ago

nateprewitt commented 4 years ago

This PR will add some basic Github Actions for our pull requests. Three workflows run that will:

  1. Run our functional and unit tests on Python 3.{6-8}
  2. Lint the Pull Request and existing code base with black and flake8
  3. Run type checking with mypy
    • This currently ignores errors from awscrt and doesn't enforce --strict. That will be handled in a future CR.
codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@b099801). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop       #2   +/-   ##
==========================================
  Coverage           ?   88.87%           
==========================================
  Files              ?       33           
  Lines              ?     1861           
  Branches           ?        0           
==========================================
  Hits               ?     1654           
  Misses             ?      207           
  Partials           ?        0           
Flag Coverage Δ
#unittests 88.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b099801...6dcd1d6. Read the comment docs.

joguSD commented 4 years ago

Is the linting and type checking running multiple times? Curious why all of the actions show up 3x.

nateprewitt commented 4 years ago

Which UI were you looking at? It should only be running twice, once for push and once for the pull request. The "Actions" tab at the top lumped in one additional run from a separate branch for some reason. The last three are for actions_cov instead of actions.