awslabs / amazon-transcribe-streaming-sdk

The Amazon Transcribe Streaming SDK is an async Python SDK for converting audio into text via Amazon Transcribe.
Apache License 2.0
142 stars 37 forks source link

Added confidence score to items #45

Closed gonzaloarro closed 3 years ago

gonzaloarro commented 3 years ago

Description of changes: Added confidence to Item class per documentation at StartStreamTranscription_ResponseSyntax and Item.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter commented 3 years ago

Codecov Report

Merging #45 (65ea45e) into develop (b482366) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
+ Coverage    88.67%   88.69%   +0.01%     
===========================================
  Files           34       34              
  Lines         1907     1910       +3     
===========================================
+ Hits          1691     1694       +3     
  Misses         216      216              
Flag Coverage Δ
unittests 88.69% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
amazon_transcribe/deserialize.py 98.09% <ø> (ø)
amazon_transcribe/model.py 91.25% <100.00%> (+0.11%) :arrow_up:
tests/unit/test_deserialize.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b482366...65ea45e. Read the comment docs.

nateprewitt commented 3 years ago

Hi @gonzaloarro, thanks for the PR! We've taken a look over the change and everything looks great. I've added a couple minor cleanup commits to get this ready to merge. I'm going to wait for a second review from @joguSD, and then I think we'll be set.