Remove GOP Settings Prompt

awslabs / amplify-video

An open source Category Plugin for the AWS Amplify-CLI that makes it easy to deploy live and file based streaming video services and integrate them into your Amplify applications.

https://www.npmjs.com/package/amplify-category-video

Apache License 2.0

269 stars 56 forks source link

Remove GOP Settings Prompt #2

Open wizage opened 5 years ago

wizage commented 5 years ago

Is your feature request related to a problem? Please describe. Instead of prompting the user to supply a GOP structure, let's hardcode it into the preset selection (HD, SD, etc). In the future, we could consider an import function that would allow for user created channel setting.

Removing this will keep the plugin quick and simple. GOP settings aren't something an application developer should care about or know how to configure. Let's do it for them.

Describe the solution you'd like Remove the GOP structure and build it into the question abstracting the values away. They would still be able to be changed just not in the prompts.

Describe alternatives you've considered Describing what a GOP is and making that more clear.

wizage commented 5 years ago

This will be changed in VoD branch. Will touch both livestream-questions.json & livestream-push.js

Example:

Would you like to use default settings?
> Default (explain)
  Sub 10 Seconds
  Advance

smp commented 5 years ago

After spending quite a bit of time thinking about this today, there's a few refactor projects necessary for live streaming:

MediaLive and Mediastore should use native cfn now that we have it
GOP / segment settings should be removed and replaced by specific medialive encoding templates
We should allow arbitrary medialive templates to be provided/selected/uploaded by the user
Origin selection should be largely abstracted away from amplify video user. We should ask things like "low latency" "DVR" or "Live to VOD" and then select the right origin for them (store/package). Perhaps in a radio button-multiselect form.

In the meantime, instead of adding more options, I'm going to gut the GOP settings prompts and hard-code them to the low-latency settings. Then, during larger refactor, we can evaluate the right way to expose different 'live streaming features' which is what I think we're trying to do by expressing these knobs, albiet in a half-hazard way at this juncture.

wizage commented 5 years ago

1) Chances of moving to ML to CF is low due to the missing features on CloudFormation (mainly start and stop). We will move if MediaPackage support comes but right now no benefit from moving. 1) As discussed above we should replace them temporary with a plain english description to fit the model of amplify. 1) Not related to this issue but I do agree. Please cut another issue for this. 1) If you want to do this instead of just removing this GOP, then I say go for it! This would be a huge win and can be scaled pretty easy to fit the other features as we make them. (This can be done now without a lot of other changes).

I would argue that at the point v1 is feature complete. We are in maintenance mode for v1 and upgrading only for security. So, the refactor can take place on the VOD branch and can go live when ever you are done.