Adding support for new CF Signed url

awslabs / amplify-video

An open source Category Plugin for the AWS Amplify-CLI that makes it easy to deploy live and file based streaming video services and integrate them into your Amplify applications.

https://www.npmjs.com/package/amplify-category-video

Apache License 2.0

267 stars 56 forks source link

Adding support for new CF Signed url #201

Closed wizage closed 3 years ago

wizage commented 3 years ago

Issue #, if available: Fixes #181

Description of changes:

Adds the ability to rotate CF Keys
Removes support for Root keys in favor of the new CloudFront public keys (migration path is easy and will happen automatically when running amplify video update and selecting rotate keys)
Fixes bug when running update and secret keys will collide.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

wizage commented 3 years ago

Also fixes random issues with CloudFront throwing weird Access Denied issues from S3 denied

wizage commented 3 years ago

Docs will need to be updated for this release.

a) Need to add in how to export private key b) Change how we talk about private keys as you no longer need root access

nathanagez commented 3 years ago

@wizage it looks like that there are some regressions when you do an amplify video add, the oldValues object is null when you do an amplify video add

Screenshot 2021-02-17 at 10 08 10

But the expected behavior for updates looks to work like a charm !

Screenshot 2021-02-17 at 10 11 07

Also, before to continue to write my tests on CF signed urls, I will wait for this PR to be merged.