awslabs / amplify-video

An open source Category Plugin for the AWS Amplify-CLI that makes it easy to deploy live and file based streaming video services and integrate them into your Amplify applications.

https://www.npmjs.com/package/amplify-category-video

Apache License 2.0

267 stars 56 forks source link

Add extra params to rSnsInvokeLambdaSetup #299

Closed conorw closed 2 years ago

conorw commented 2 years ago

Add env, GraphQLAPIId & GraphQLEndpoint to rSnsInvokeLambdaSetup

Issue #, if available: 298 https://github.com/awslabs/amplify-video/issues/298

Description of changes: Adds env, GraphQLAPIId & GraphQLEndpoint to rSnsInvokeLambdaSetup

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pedramp20 commented 2 years ago

this merge is causing push to fail. As the GraphQLAPIId & GraphQLEndpoint are added to the main template but not to SnsSetup template as a result. Push fails with the following error message:

amplify vod rSnsInvokeLambdaSetup AWS::CloudFormation::Stack ...... Parameters: [GraphQLAPIId, GraphQLEndpoint] do not exist in the template @conorw

wizage commented 2 years ago

314 just forgot the merge that patch that fixed this

wizage commented 2 years ago

Should be live in about 5 minutes @pedramp20

pedramp20 commented 2 years ago

Are you sure it is merged? https://github.com/awslabs/amplify-video/blob/release/3.9.1/provider-utils/awscloudformation/cloudformation-templates/vod-helpers/SnsSetup.template.ejs still does not contain the GraphQLAPIId, GraphQLEndpoint parameters.

@wizage