search

awslabs / app-development-for-backstage-io-on-aws

A developer portal to meet your Enterprise needs. Fast, secure, and at-scale.
https://opaonaws.io/
Apache License 2.0
160 stars 28 forks source link

Unnecessary Gitlab plugin for non-Gitlab installations #26

Open jsundquist opened 10 months ago

jsundquist commented 10 months ago

Today I was trying out the plugins and ran into an issue that took me a while to figure out. It seems as though the @aws/plugin-aws-apps-for-backstage has a hard dependency on @immobiliarelabs/backstage-plugin-gitlab.

https://github.com/jsundquist/app-development-for-backstage-io-on-aws/blob/b4ca0946f083dd95272807c86e6c663ae5336dda/backstage-plugins/plugins/aws-apps/src/plugin.ts#L24-L37

Please consider removing the Gitlab gitlab plugin and related dependencies so the plugins can be used in projects that do not require Gitlab.

z-sourcecode commented 9 months ago

Hi @jsundquist thanks for your feedback. We currently do have a dependency on immobiliarelabs. In the next few days/weeks we will release a 2nd version of the solution with many more features. However, we have taken a dependency on gitlabs and as a result on immobiliarelabs plugin. We may change this in the future so customers can easily interchange their source control / CI/CD tools.

I'm tagging this as feature request.

jsundquist commented 9 months ago

@z-sourcecode I dug through the code after filing the issue and from what I could tell, it looks as though the Gitlab dependency is more for demo purposes to show what a custom CI/CD tab could look like. Would it be possible to move that custom entity page to the demo app and remove it from the plugin itself?

I would be happy to move the code around slight to provide what I described above even if it is short lived until an updated version with different components is released.

z-sourcecode commented 9 months ago

Hi @jsundquist , Thanks for your response. that's correct. however we are about to release an updated release that will use gitlab in few places and in our core pipelines as well so at the moment we do have a dependency on gitlab.

jsundquist commented 9 months ago

Is there a reason for more gitlab integration? It feels as though then this plugin for Backstage will be discouraging users for GitHub or Bitbucket from using this particular plugin or resorting to forking it to make it more generic.

z-sourcecode commented 9 months ago

Yes, we built this a solution for a customer which asked this specifically. that being said , we will plan to accommodate other common CI/CD / SCM tools in the future.