Added new alb log format support

awslabs / athena-glue-service-logs

Glue scripts for converting AWS Service Logs for use in Athena

Apache License 2.0

142 stars 46 forks source link

Added new alb log format support #2

Closed yutachaos closed 5 years ago

yutachaos commented 5 years ago

Issue #, if available:

Description of changes:

Added a missing field to ALB log format
- matched_rule_priority,request_creation_time,actions_executed,redirect_url
fyi
- https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-access-logs.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dacort commented 5 years ago

Thanks, @yutachaos, for the contribution! The repo is frozen until after AWS' re:Invent next week, but I'll take a look at this once that's wrapped up.

yutachaos commented 5 years ago

Thank you for comments. Fixed it.

dacort commented 5 years ago

Thanks, will test this out soon!

HelioCampos commented 5 years ago

Does this still require changes @dacort? It seems the @yutachaos already made the modifications you asked him. Best regards,

dacort commented 5 years ago

@HelioCampos Thanks for the bump. I just tested this out and looks like there is a step missing that results in incompatible schema. @yutachaos if it's OK with you, I'll likely close this PR and open another one since the code around that area is a little suboptimal and there's also a new ALB field. :)

dacort commented 5 years ago

Moved into PR #9