search

awslabs / athena-glue-service-logs

Glue scripts for converting AWS Service Logs for use in Athena
Apache License 2.0
142 stars 45 forks source link

README says to use "service_name=xxx" but Makefile expects "service=xxx" #5

Closed leecookson closed 5 years ago

leecookson commented 5 years ago

example:

Error:

make create_job service_name=cloudfront
'service' variable must be defined
make: *** [require_service] Error 1

Success:

make create_job service=cloudfront
test -n CloudFront_Partitioner || (echo "cloudfront service not found" && echo 1)
aws glue create-job --name CloudFront_Partitioner_LogMaster_v5.3.0 \
        --description "CloudFront_Partitioner Log infra generator" \
        --role AWSGlueServiceRoleDefault \
...
...
$ make --version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
dacort commented 5 years ago

@leecookson Ack, you're right - sorry about that! Will update accordingly.