search

awslabs / automated-security-helper

https://awslabs.github.io/automated-security-helper/
Apache License 2.0
361 stars 44 forks source link

Scanner option to cancel the run, when there are many files in `--source-dir` not working #53

Closed climbertjh2 closed 3 months ago

climbertjh2 commented 4 months ago

With the latest updates, it looks like the option to cancel the run of the scan when there are "many" files in the source directory is no longer working.

It may be due to the scan script being run in a container now, so the sleep/delay is not interruptable/stoppable with a CTRL-C entry.

Symptom: see the following in the output, attempt CTRL-C to stop ... but the scan does not stop:

ASH found 9147 file(s) in the source directory...
Depending on your machine this might take a while...
Waiting 5 seconds in case you want to stop (use CTRL-C)...
awsntheule commented 3 months ago

Hey Tim, PR #71 should fix this. Please confirm that this issue is resolved.

climbertjh2 commented 3 months ago

I tested this today - it is working again!

Thank you. Closing this one.