awslabs / automated-security-helper

https://awslabs.github.io/automated-security-helper/
Apache License 2.0
361 stars 44 forks source link

v1.3.0 - grype and syft scanners are not running against items in git repositories #72

Closed climbertjh2 closed 3 months ago

climbertjh2 commented 3 months ago

I have found that with v1.3.0, the grype and syft scanners are not scanning files that they should - but only when the --source-dir is set at a git repository. If the --source-dir is not a git repository root, then the scanners find the files.

I have narrowed this down to the use of a --tmpfs mount for the container run.

climbertjh2 commented 3 months ago

I am working on a PR for this.

scrthq commented 3 months ago

This looks good as of PR #73 ! Ready to close when you are done confirming from my perspective, I'm seeing Syft kicking in again where I wasn't previously

climbertjh2 commented 3 months ago

Yes - this is fixed now. Closing.