search

awslabs / automated-security-helper

https://awslabs.github.io/automated-security-helper/
Apache License 2.0
361 stars 44 forks source link

Inconsistent behavior when running ash inside the ash container vs. running ash outside of the ash container #75

Closed climbertjh2 closed 3 months ago

climbertjh2 commented 3 months ago

There is a subtle inconsistency when running ash. This has to do with whether or not the --output-dir folder is specified on the command-line options.

When running outside of the container itself, if --output-dir is not specified, then a ash_output folder is created under the --source-dir folder.

However, when running ash from inside its own container (which is the recommended way to use it when running in a build automation environment), if --output-dir is not specified, then the folder is NOT created and output is placed in the --source-dir.

This behavior should be made to be consistent.

climbertjh2 commented 3 months ago

PR #74 - implements a fix for this.

climbertjh2 commented 3 months ago

This is fixed. Closing.