fixes to ml-training-on-eks module/manifest

awslabs / autonomous-driving-data-framework

ADDF is a collection of modules, deployed using the SeedFarmer orchestration tool. ADDF modules enable users to quickly bootstrap environments for the process and analysis of autonomous driving data.

Apache License 2.0

112 stars 44 forks source link

fixes to ml-training-on-eks module/manifest #558

Closed ciupras closed 4 months ago

ciupras commented 4 months ago

Issue #, if available:

Description of changes:

added eks-handler-rolearn required for AssumeRole for aws_eks Cluster kubectl_lambda_role attribute
module training ref to proper git repo release number
modification of README.md contains proper string for eks-oidc-arn and added eks-handler-rolearn

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ciupras commented 4 months ago

I have another not solved yet issue related to the deployspec.yaml and modulestack.yaml. This section is troublesome, where in general Error output is that CodeBuild role is not allowed to AssumeRole of ${SEEDFARMER_PARAMETER_EKS_CLUSTER_ADMIN_ROLE_ARN} - link

srinivasreddych commented 4 months ago

Thanks for your contribution @ciupras . Pls add the below to the PR:

changelog
point to eks 1.8 release here and the datafiles below the mentioned line
from the root of repo, please run ./scripts/fix.sh --language python --path modules/ml-training/training-k8s-deployment which will fix the formatting issues

ciupras commented 4 months ago

Requested changes applied to the PR. Thanks for cooperation!