search

awslabs / aws-api-gateway-developer-portal

A Serverless Developer Portal for easily publishing and cataloging APIs
Apache License 2.0
931 stars 401 forks source link

Allow usage of existing user pool #279

Closed nimrodkor closed 3 years ago

nimrodkor commented 5 years ago

Description of changes: Added two parameters to allow usage of existing User Pool instead of creating a new one.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ghost commented 4 years ago

Could you fix the merge conflicts?

nimrodkor commented 4 years ago

@amazon-meaisiah Done!

nimrodkor commented 4 years ago

Hey again @amazon-meaisiah !

I tested it out on our environment - and for some reason, the URL for the existing cognito user pool is broken in the UI. When I try to sign in, it sends me to https://developers.test.com/<COGNITO_URL> Instead of https://<COGNITO_URL>. Tried to fix it but had a hard time. Any possible help here?

ghost commented 4 years ago

@nimrodkor Not sure personally based on a cursory look at the code, but I'll see if I can work with other team members to figure out what's going on or if I just missed something.

nimrodkor commented 4 years ago

@amazon-meaisiah Removed the temp files, sorry about that!

talipini commented 3 years ago

@nimrodkor - Looks like this change was merged in a while ago but it is not in the latest any more. Any ideas on what happened to it? Were there any issues with this? thanks