Create a real test file for the pre-signup trigger, so it's validated. (Also, this makes the tests pass again.)
Fix various errors in the templates.
PreventUserExistenceErrors is not a boolean value, but a string enumeration, and so CFN itself rightfully rejected it.
CognitoDomainAcmCertArn corresponds to a commented-out field, and while it doesn't directly break deployments, I'd expect its presence to affect SAR releases.
The default CloudFront distribution is conditioned on NoCustomDomainName, and this isn't merely !Not [!Condition UseCustomDomainName] - it also asserts NotDevelopmentNode (!Not [!Condition DevelopmentMode]) similarly to UseCustomDomainName - and so cfn-lint's error there was in fact valid.
A few lines were returning strings when the stated type was different. (CFN still accepted them, but cfn-lint was warning about them.)
Fix the reset-assets task to also clean up old untracked files. (git checkout wasn't sufficient - it left untracked files intact.)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available:
Description of changes:
PreventUserExistenceErrors
is not a boolean value, but a string enumeration, and so CFN itself rightfully rejected it.CognitoDomainAcmCertArn
corresponds to a commented-out field, and while it doesn't directly break deployments, I'd expect its presence to affect SAR releases.NoCustomDomainName
, and this isn't merely!Not [!Condition UseCustomDomainName]
- it also assertsNotDevelopmentNode
(!Not [!Condition DevelopmentMode]
) similarly toUseCustomDomainName
- and so cfn-lint's error there was in fact valid.reset-assets
task to also clean up old untracked files. (git checkout
wasn't sufficient - it left untracked files intact.)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.