awslabs / aws-api-gateway-developer-portal

A Serverless Developer Portal for easily publishing and cataloging APIs
Apache License 2.0
927 stars 399 forks source link

StaticAssetUploaderLambdaFunction errors with PublicAccessBlockConfiguration: #429

Open jimomulloy opened 4 years ago

jimomulloy commented 4 years ago

In Version 4.0.x - when creating a devportal (in developer mode) I see errors in the StaticAssetUploaderLambdaFunction console and the stack does not complete create.

It seems if I remove the PublicAccessBlockConfiguration: fromr the S3 buckets DevPortalSiteS3Bucket when in Dev mode it works OK:

PublicAccessBlockConfiguration: BlockPublicAcls: true BlockPublicPolicy: true IgnorePublicAcls: true RestrictPublicBuckets: true

Unhandled Promise Rejection
{ "errorType": "Runtime.UnhandledPromiseRejection", "errorMessage": "AccessDenied: Access Denied", "reason": { "errorType": "AccessDenied", "errorMessage": "Access Denied", "code": "AccessDenied", "message": "Access Denied", "region": null, "time": "2020-07-21T14:02:46.389Z", "requestId": "B259B22412D19E07",

jimomulloy commented 3 years ago

Hi Devportal team.

Please can we get a response to this issue.

We make good use of the AWS Devportal in our company (Visionhealth ltd) to present our AWS Cloud based service's OpenAPI documentation.

We also need the "Dev" flag to do our development.

So it is essential we have a resolution to this issue if at all possible.

Many thanks from Jim O'Mulloy (Vision Health ltd.)

jimomulloy commented 3 years ago

by the way I have made fork that does work - by adding something this to the code. I am not confident this is the correct approach to make a PR though. ..... DevPortalSiteS3Bucket: Type: AWS::S3::Bucket Properties: BucketName: !Ref DevPortalSiteS3BucketName PublicAccessBlockConfiguration: BlockPublicAcls: !If [ NotDevelopmentMode, 'true', 'false' ] BlockPublicPolicy: !If [ NotDevelopmentMode, 'true', 'false' ] IgnorePublicAcls: !If [ NotDevelopmentMode, 'true', 'false' ] RestrictPublicBuckets: !If [ NotDevelopmentMode, 'true', 'false' ]

jimomulloy commented 3 years ago

Hi - this issue still open after 6 months - please let us know if there is a solution ? thanks