search

awslabs / aws-api-gateway-developer-portal

A Serverless Developer Portal for easily publishing and cataloging APIs
Apache License 2.0
927 stars 399 forks source link

.promise() missing from static-asset-uploader cleanS3Bucket ... await s3.deleteObjects #431

Open jimomulloy opened 3 years ago

jimomulloy commented 3 years ago

In latest V4/staging it seems that static-asset-uploader handler fails to delete S3 contents due to missing ".promsie()" in call to s3.deleteObjects in cleanS3Bucket.

Maybe should be?....

const result = await s3.deleteObjects({ Bucket: bucketName, Delete: { Objects: keys } }).promise()

ghost commented 3 years ago

Try what's in master - that should have that bug fixed.

jimomulloy commented 3 years ago

Hi - same issue still open after 6 months - a fix does NOT appear to be in master as per your last comment - please let us know asap what the solution is? thanks