search

awslabs / aws-api-gateway-developer-portal

A Serverless Developer Portal for easily publishing and cataloging APIs
Apache License 2.0
924 stars 399 forks source link

Output Cloudfront Distribution domain name #491

Closed NickLarsenNZ closed 4 weeks ago

NickLarsenNZ commented 3 years ago

Fixes #490

Description of changes: Always output the Cloudfront domain name so that DNS records can be managed automatically, but externally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

NickLarsenNZ commented 3 years ago

Looks like my formatter removed some whitespace too. I'll leave it as is, but if you'd like I can move those to a separate commit.

NickLarsenNZ commented 3 years ago

Also, looks like CI is broken:

npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/awslabs/swagger-ui.git
npm ERR! 
npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.113.4' to the list of known hosts.
npm ERR! Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
ghost commented 3 years ago

Also, looks like CI is broken:

npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/awslabs/swagger-ui.git
npm ERR! 
npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.113.4' to the list of known hosts.
npm ERR! Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.

@NickLarsenNZ Try again. I've pushed a new commit that should alleviate that. (I changed it to pull from HTTP rather than SSH.)

NickLarsenNZ commented 2 years ago

@amazon-meaisiah sorry for taking so long, had completely forgotten about this. I've fixed the merge conflict and it's now passed CI checks.