awslabs / aws-athena-query-federation

The Amazon Athena Query Federation SDK allows you to customize Amazon Athena with your own data sources and code.
Apache License 2.0
562 stars 297 forks source link

add quotes around oracle password #2399

Closed aimethed closed 1 week ago

aimethed commented 1 week ago

Currently if a secret is used for username and password, if the password is not encased in double quotes, it will cause an error (this is documented in the oracle DB documentation). This change checks to make sure the password is not already inside of double quotes (to not break existing customers using double quotes). If it is not, it adds the double quotes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.