awslabs / aws-athena-query-federation

The Amazon Athena Query Federation SDK allows you to customize Amazon Athena with your own data sources and code.
Apache License 2.0
562 stars 297 forks source link

[FEATURE] Feature request: I want to filter DynamoDB tables into Athena #606

Closed vaquarkhan closed 1 year ago

vaquarkhan commented 2 years ago

Is your feature request related to a problem? If yes, please describe. Yes User want control to display only selected tables into Athena .

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

User has multiple teams and tables also contain KMS key few are configured via Lake formation , now I can see following issues.

Describe the solution you'd like A clear and concise description of what you want to happen. Want a filter where i can configure my tables which will display in Athena,

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

I have fixed code in following branch , raising pull request please review . https://github.com/vaquarkhan/aws-athena-query-federation/tree/master/athena-dynamodb

Additional context Add any other context or screenshots about the feature request here.

I have tested all possible scenario in committed code. image image

I have no expertise in cloud formation so i am adding Lambda parameter manually if you could add into your template cloud formation would be great help

vaquarkhan commented 2 years ago

Pull request for review

chngpe commented 1 year ago

Hi

Thank you for reaching out.

Asking permission for KMS key which own by other team is big issue as they are not comfortable to share this keys and since I have my 4 -5 tables which I want to use in Athena blocked by others team.

We decide to approach this differently, rather than customer has to provide filter to filter out the table, we decide to skip table when customer doesn't have access to the encrypted table in dynamoDB.

We have added support in our latest version of connector to skip the dynamoDB table for kms encrypted table when lambda role doesn't have sufficient permission to access KMS key.

Closing ticket, if you have additional questions feel free to reopen this.