hackett123
commented
2 years ago Investigated further. for 1) there's nothing for the federation team to do, the issue really boils down to an unclear error from the cdk and is solvable with a quick google search of the error. for 2) I misinterpreted the errors I was facing, there's really just a lot of malformed json files. The integ test package correctly sees empty values for optional fields as valid. Created PR for fixing JSON files and introducing a tool to watch out for errors in the future here - https://github.com/awslabs/aws-athena-query-federation/pull/741
Will write the fix for this later, mostly adding as a TODO. The Timestream integration tests will fail under the two following circumstances that need to fixed or called out: 1) If you don't have node.js installed on your machine, the integ tests can't kick off. This is because we need node js to run the aws cdk. 2) If you don't specify VPC settings in the test-config.json file, the tests will fail to start as well, even though the connector has no concept of VPC setup.