Closed graebm closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.36%. Comparing base (
3281f86
) to head (c19df6f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue: If the external process logged to
stderr
during a normal successful run, the credentials would fail to parse.This was happening because the credentials-provider would always combine
stderr
andstdout
by appending2>&1
to the external command. Then JSON parsing would fail, due to random lines of logging onstderr
mixing with valid JSON onstdout
.Description of changes: Instead of redirecting
stderr
tostdout
, redirect it to/dev/null
.It would be better to capture
stderr
separately, and display it if the external process fails. Butaws_process_run()
doesn't currently capturestderr
, and would require a rework to do so.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.