search

awslabs / aws-c-common

Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.
Apache License 2.0
262 stars 159 forks source link

Consistently use lowercase for Windows libraries and header files #1058

Closed giordano closed 9 months ago

giordano commented 1 year ago

Windows typically uses case-insensitive file systems, so the case of libraries and header files is irrelevant, but MinGW consistently use lowercase names everywhere, and when cross-compiling on Linux systems with case-sensitive file systems the case of these names is very much relevant.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

graebm commented 1 year ago

It's failing to build with MSVC (see CI links)

giordano commented 1 year ago

Ok, I removed the include of winnt.h which was orthogonal to the cases problem, I think it was something like #1059 but now I don't remember what it was needed for exactly.