search

awslabs / aws-c-common

Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.
Apache License 2.0
262 stars 159 forks source link

MIT license should be included in extra licenses file #1060

Closed bkmgit closed 1 year ago

bkmgit commented 1 year ago

Describe the bug

The cJSON header from https://github.com/DaveGamble/cJSON is available under MIT license, and so should also be listed in the THIRD-PARTY-LICENSE.txt file

Expected Behavior

THIRD-PARTY-LICENSES.txt should contain all third party license

Current Behavior

THIRD-PARTY-LICENSE.txt contains only one license, BSD-3-Clause

Reproduction Steps

Examine the file https://github.com/awslabs/aws-c-common/blob/main/THIRD-PARTY-LICENSES.txt

Possible Solution

Update the file https://github.com/awslabs/aws-c-common/blob/main/THIRD-PARTY-LICENSES.txt

Additional Information/Context

No response

aws-c-common version used

0.9.3

Compiler and version used

gcc 15

Operating System and version

Fedora 40 (rawhide)

yasminetalby commented 1 year ago

Hello @bkmgit ,

Thank you very much for your submission. You are right cJSON header from DaveGamble/cJSON used here is under the MIT License (reference to their LICENSE file. We do currently include their license at the top of our cJSON.c file.

I am not sure why it is not referred to in the THIRD-PARTY-LICENSE.txt .

I'll submit a fix for it.

Thank you very much for reporting this. We really appreciate your time and feedback!

Best regards,

Yasmine

jmklix commented 1 year ago

License PR merge. Closing this issue