codecov-commenter
commented
1 year ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
00157ef) 83.42% compared to head (5890c1a) 83.40%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1076 +/- ## ========================================== - Coverage 83.42% 83.40% -0.02% ========================================== Files 56 56 Lines 5792 5792 ========================================== - Hits 4832 4831 -1 - Misses 960 961 +1 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-common/pull/1076?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/posix/system\_info.c](https://app.codecov.io/gh/awslabs/aws-c-common/pull/1076?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3Bvc2l4L3N5c3RlbV9pbmZvLmM=) | `26.75% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-common/pull/1076/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue #, if available: https://github.com/aws/aws-cli/issues/8320
Description of changes:
g_numa_num_configured_nodes_ptrreturns 0 which breaks assumption of our system that cpu_group_count will be at least 1 and crashes at https://github.com/awslabs/aws-c-s3/blob/main/source/s3_platform_info.c#L317.aws_get_cpu_count_for_groupcan also return 0 but we do throw proper error if it is 0.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.