awslabs / aws-c-common

Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.
Apache License 2.0
262 stars 159 forks source link

Fix a bunch of places we forget to aws_raise_error() #1089

Closed graebm closed 9 months ago

graebm commented 9 months ago

Our error handling strategy is simple to explain, but easy to get wrong. Inspired by this PR that fixed some obviously-incorrect-code, I decided to search for more easy-to-spot accidents:

TODO in the future:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7f55a9c) 83.23% compared to head (fbb4e2d) 83.15%.

Files Patch % Lines
source/json.c 0.00% 2 Missing :warning:
source/logging.c 0.00% 2 Missing :warning:
source/log_formatter.c 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1089 +/- ## ========================================== - Coverage 83.23% 83.15% -0.08% ========================================== Files 56 56 Lines 5808 5813 +5 ========================================== Hits 4834 4834 - Misses 974 979 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.