search

awslabs / aws-c-common

Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.
Apache License 2.0
263 stars 159 forks source link

Add support for WIN ARM64 #1092

Closed alfred2g closed 8 months ago

alfred2g commented 9 months ago

Add support for ARM64 on Windows

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.10%. Comparing base (7f55a9c) to head (a01eaba). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1092 +/- ## ========================================== - Coverage 83.23% 83.10% -0.13% ========================================== Files 56 56 Lines 5808 5766 -42 ========================================== - Hits 4834 4792 -42 Misses 974 974 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alfred2g commented 8 months ago

At first glance, this looks correct... but I'm not an expert in the arm64 memory model. How have we tested this for correctness?

@bdonlan, We already have race test cases to test for value coherence, and indeed one failed without the changes.. if you have suggestions for a new testcase we can implement, it would be great