Closed graebm closed 8 months ago
Attention: Patch coverage is 96.96970%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 83.04%. Comparing base (
15a2534
) to head (f5b90ec
).
Files | Patch % | Lines |
---|---|---|
source/date_time.c | 96.96% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue:
aws_date_time
did not accept "2024-02-23 23:06:27+00:00", despite that being a valid RFC 3339 timestamp.Background:
aws_date_time
has enums for ISO_8601, but does not claim to support every single optionaws_date_time
does not fully support RFC 3339. The unsupported features in the string above were: 1) Space instead of "T" between date and time 2) "+00:00" offset instead of "Z" after timeDescription of changes:
ISO_8601
andISO_8601_BASIC
into 1 function.ISO_8601
orISO_8601_BASIC
enum is passed in.ISO_8601
code already allowed separators to be omitted from time, which shows evidence that lenience is good.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.