search

awslabs / aws-c-common

Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.
Apache License 2.0
262 stars 159 forks source link

claim range for aws-crt-kotlin #1095

Closed aajtodd closed 8 months ago

aajtodd commented 8 months ago

Issue #, if available: n/a

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.04%. Comparing base (fcadc0d) to head (a0b7ce5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1095 +/- ## ======================================= Coverage 83.04% 83.04% ======================================= Files 56 56 Lines 5762 5762 ======================================= Hits 4785 4785 Misses 977 977 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aajtodd commented 8 months ago

Looks like package slots is capped at 16

Using package ID of 16 results in:

Bad log subject slot index 0x0000000000000010

What do you want this updated to? 17? 24? 32?

graebm commented 8 months ago

32 seems fine. Good old powers of two