search

awslabs / aws-c-common

Core c99 package for AWS SDK for C. Includes cross-platform primitives, configuration, data structures, and error handling.
Apache License 2.0
263 stars 159 forks source link

Move is ipv4/ipv6 functions from Aws-c-sdkutils to Aws-c-common #1105

Closed waahm7 closed 7 months ago

waahm7 commented 7 months ago

Description of changes: Moves host_utils into Aws-c-common so that we can use them in all repos. Fixed the ::1 case by making the following two changes.

  1. removed _starts_with(substr,':') condition because it can start with :
  2. Added the group_count>2 condition while checking the group count and double colon loop.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.27%. Comparing base (86e9e27) to head (7b18784).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1105 +/- ## ========================================== + Coverage 83.06% 83.27% +0.21% ========================================== Files 56 57 +1 Lines 5768 5812 +44 ========================================== + Hits 4791 4840 +49 + Misses 977 972 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.