awslabs / aws-c-http

C99 implementation of the HTTP/1.1 and HTTP/2 specifications
Apache License 2.0
136 stars 42 forks source link

Websocket: Validate UTF-8 in text payloads #418

Closed graebm closed 1 year ago

graebm commented 1 year ago

Issue: Websocket was not validating text payloads, as required by RFC-6455 Section 5.6

Description of changes: Now it is!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Base: 79.50% // Head: 79.44% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (89715c2) compared to base (9bd58ca). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #418 +/- ## ========================================== - Coverage 79.50% 79.44% -0.07% ========================================== Files 27 27 Lines 11912 11934 +22 ========================================== + Hits 9471 9481 +10 - Misses 2441 2453 +12 ``` | [Impacted Files](https://codecov.io/gh/awslabs/aws-c-http/pull/418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/websocket.c](https://codecov.io/gh/awslabs/aws-c-http/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3dlYnNvY2tldC5j) | `82.66% <100.00%> (+0.02%)` | :arrow_up: | | [source/websocket\_decoder.c](https://codecov.io/gh/awslabs/aws-c-http/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3dlYnNvY2tldF9kZWNvZGVyLmM=) | `100.00% <100.00%> (ø)` | | | [source/h2\_connection.c](https://codecov.io/gh/awslabs/aws-c-http/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2gyX2Nvbm5lY3Rpb24uYw==) | `82.83% <0.00%> (-1.16%)` | :arrow_down: | | [source/connection\_manager.c](https://codecov.io/gh/awslabs/aws-c-http/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `88.21% <0.00%> (+0.57%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.