search

awslabs / aws-c-io

This is a module for the AWS SDK for C. It handles all IO and TLS work for application protocols.
Apache License 2.0
109 stars 61 forks source link

Revert "Intel Vtune Markers for EventLoop and InputStream Read (#596)" #616

Closed deej-io closed 8 months ago

deej-io commented 9 months ago

Issue: #615.

Description of changes: This reverts commit b4aa873e16db0824ad381ae78764d445ae62ee32.

The original commit introduced linker errors if Intel VTune was not installed as a system dependency.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

waahm7 commented 9 months ago

Are you using the latest version of aws-c-common? Aws-c-common defines a macro which strips out intel vtune unless enabled https://github.com/awslabs/aws-c-common/pull/1050/files#diff-9b6ea2bf68ed273a9e82a3ef8e0b10a0b3105c67f71719cc879d27c0bcce8dafR254.

deej-io commented 9 months ago

Closing as issue is not with this repository but with awslabs/aws-c-io or awslabs/aws-crt-cpp.