search

awslabs / aws-c-io

This is a module for the AWS SDK for C. It handles all IO and TLS work for application protocols.
Apache License 2.0
105 stars 58 forks source link

Fix signed/unsigned bug with aws_future_wait() timeout value #638

Closed graebm closed 2 months ago

graebm commented 2 months ago

A timeout of UINT64_MAX would be treated as a negative number, and immediately time out 😬

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.06%. Comparing base (7e04b86) to head (db6c756).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #638 +/- ## ========================================== - Coverage 80.11% 80.06% -0.05% ========================================== Files 28 28 Lines 5964 5965 +1 ========================================== - Hits 4778 4776 -2 - Misses 1186 1189 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.