awslabs / aws-c-io

This is a module for the AWS SDK for C. It handles all IO and TLS work for application protocols.
Apache License 2.0
109 stars 61 forks source link

Fix memory leaks in Windows TLS code #652

Closed graebm closed 2 months ago

graebm commented 3 months ago

Issue:

A C++ SDK user found a memory leak in the Windows TLS channel-handler code and submitted the following PR: https://github.com/awslabs/aws-c-io/pull/651

In evaluating this 2-line fix, I noticed that it sat in the middle of some (preexisting) sloppy error-handling.

Description of changes:

Co-authored-by: @normanade

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.22%. Comparing base (9072f86) to head (5720360).

Files Patch % Lines
source/channel.c 66.66% 1 Missing :warning:
source/s2n/s2n_tls_channel_handler.c 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #652 +/- ## ========================================== + Coverage 80.12% 80.22% +0.10% ========================================== Files 28 28 Lines 5967 5957 -10 ========================================== - Hits 4781 4779 -2 + Misses 1186 1178 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.