search

awslabs / aws-c-mqtt

C99 implementation of the MQTT 3.1.1 specification.
Apache License 2.0
93 stars 30 forks source link

Vtable refactor311 #280

Closed bretambrose closed 1 year ago

bretambrose commented 1 year ago

Refactors the mqtt311 implementation into two pieces: a generic wrapper with a vtable and the actual implementation. This will allow us to have a second implementation based on the mqtt5 client that honors the 311 interface.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 74.86% and project coverage change: -0.01 :warning:

Comparison is base (e6ea3cc) 81.27% compared to head (a388ee6) 81.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #280 +/- ## ========================================== - Coverage 81.27% 81.27% -0.01% ========================================== Files 16 17 +1 Lines 7209 7273 +64 ========================================== + Hits 5859 5911 +52 - Misses 1350 1362 +12 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/client.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2NsaWVudC5j) | `65.29% <72.65%> (+0.28%)` | :arrow_up: | | [source/client\_impl\_shared.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2NsaWVudF9pbXBsX3NoYXJlZC5j) | `77.77% <77.77%> (ø)` | | | [source/client\_channel\_handler.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2NsaWVudF9jaGFubmVsX2hhbmRsZXIuYw==) | `70.02% <85.71%> (+0.15%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.