awslabs / aws-c-mqtt

C99 implementation of the MQTT 3.1.1 specification.
Apache License 2.0
93 stars 30 forks source link

Mqtt3-to-5 Adapter Config APIs #286

Closed bretambrose closed 1 year ago

bretambrose commented 1 year ago

Tests added for what can actually be checked in the unit test framework. Proxy and websocket correctness will need integration tests run in codebuild which we don't have set up yet for aws-c-mqtt.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 38.59% and project coverage change: -1.47 :warning:

Comparison is base (56cf5e2) 81.20% compared to head (5d1c5e4) 79.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## RefactorAdapterRefcount #286 +/- ## =========================================================== - Coverage 81.20% 79.74% -1.47% =========================================================== Files 18 18 Lines 7322 7621 +299 =========================================================== + Hits 5946 6077 +131 - Misses 1376 1544 +168 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/mqtt3\_to\_mqtt5\_adapter.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL21xdHQzX3RvX21xdHQ1X2FkYXB0ZXIuYw==) | `45.45% <38.59%> (-30.74%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/286/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.