awslabs / aws-c-mqtt

C99 implementation of the MQTT 3.1.1 specification.
Apache License 2.0
93 stars 29 forks source link

Adapter cleanup #290

Closed bretambrose closed 1 year ago

bretambrose commented 1 year ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 36.70% and project coverage change: -1.08 :warning:

Comparison is base (a661c9d) 81.20% compared to head (6506221) 80.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #290 +/- ## ========================================== - Coverage 81.20% 80.13% -1.08% ========================================== Files 18 18 Lines 7322 7585 +263 ========================================== + Hits 5946 6078 +132 - Misses 1376 1507 +131 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/client\_impl\_shared.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2NsaWVudF9pbXBsX3NoYXJlZC5j) | `80.95% <ø> (+3.67%)` | :arrow_up: | | [source/mqtt.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL21xdHQuYw==) | `94.59% <ø> (ø)` | | | [source/v5/mqtt5\_client.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3Y1L21xdHQ1X2NsaWVudC5j) | `87.56% <7.69%> (-0.79%)` | :arrow_down: | | [source/mqtt3\_to\_mqtt5\_adapter.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL21xdHQzX3RvX21xdHQ1X2FkYXB0ZXIuYw==) | `42.50% <35.84%> (-33.70%)` | :arrow_down: | | [source/client.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL2NsaWVudC5j) | `69.03% <80.00%> (+3.42%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/290/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.