awslabs / aws-c-mqtt

C99 implementation of the MQTT 3.1.1 specification.
Apache License 2.0
93 stars 29 forks source link

311 adapter lifecycle foundations #293

Closed bretambrose closed 1 year ago

bretambrose commented 1 year ago

Misc. functionality needed to support connect/disconnect and lifecycle events in the 311_to_5 adapter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 53.78% and project coverage change: -0.18 :warning:

Comparison is base (d3377e4) 80.34% compared to head (96d45cb) 80.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #293 +/- ## ========================================== - Coverage 80.34% 80.17% -0.18% ========================================== Files 18 18 Lines 7571 7625 +54 ========================================== + Hits 6083 6113 +30 - Misses 1488 1512 +24 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/mqtt.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL21xdHQuYw==) | `94.59% <ø> (ø)` | | | [source/v5/mqtt5\_client.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3Y1L21xdHQ1X2NsaWVudC5j) | `87.63% <8.33%> (-0.72%)` | :arrow_down: | | [source/mqtt3\_to\_mqtt5\_adapter.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL21xdHQzX3RvX21xdHQ1X2FkYXB0ZXIuYw==) | `45.27% <58.87%> (+2.77%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.