awslabs / aws-c-mqtt

C99 implementation of the MQTT 3.1.1 specification.
Apache License 2.0
93 stars 30 forks source link

Adapter lifecycle2 #295

Closed bretambrose closed 1 year ago

bretambrose commented 1 year ago

Placeholder for easy diff. Won't be merging

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 10.11% and project coverage change: -1.54 :warning:

Comparison is base (865220a) 80.15% compared to head (48c28f5) 78.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## AdapterLifecycle1 #295 +/- ## ===================================================== - Coverage 80.15% 78.62% -1.54% ===================================================== Files 18 18 Lines 7600 7770 +170 ===================================================== + Hits 6092 6109 +17 - Misses 1508 1661 +153 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/v5/mqtt5\_client.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3Y1L21xdHQ1X2NsaWVudC5j) | `87.56% <0.00%> (ø)` | | | [source/mqtt3\_to\_mqtt5\_adapter.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL21xdHQzX3RvX21xdHQ1X2FkYXB0ZXIuYw==) | `33.21% <10.28%> (-11.33%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.